Skip to content

Fix fftconvolve axis handling#3630

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fftconvolve-bool-axes-20260701
Open

Fix fftconvolve axis handling#3630
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fftconvolve-bool-axes-20260701

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary:

  • Treat Python boolean axes as scalar integer axes in the PyTorch fftconvolve wrapper.
  • Add regression tests for axes False and True.
  • Keep NumPy boolean scalar axes rejected.

Tests: regression tests added for CI.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 74.84s
✅ JSON prettier 7 0 0 0 1.01s
✅ JSON v8r 7 0 0 5.49s
✅ MARKDOWN markdownlint 68 0 0 0 1.87s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.7s
✅ PYTHON black 1183 28 0 0 72.76s
✅ PYTHON isort 1183 50 0 0 3.51s
✅ REPOSITORY checkov yes no no 55.13s
✅ REPOSITORY gitleaks yes no no 11.2s
✅ REPOSITORY git_diff yes no no 0.24s
✅ REPOSITORY secretlint yes no no 61.04s
✅ REPOSITORY syft yes no no 4.08s
✅ REPOSITORY trivy-sbom yes no no 4.22s
✅ REPOSITORY trufflehog yes no no 14.67s
✅ YAML prettier 11 0 0 0 0.79s
✅ YAML v8r 11 0 0 12.41s
✅ YAML yamllint 11 0 0 0.62s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FlorianPfaff